feat: basic in-memory de-duping revalidation queue #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e134601 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
vicb
reviewed
Feb 10, 2025
vicb
reviewed
Feb 10, 2025
vicb
reviewed
Feb 10, 2025
vicb
reviewed
Feb 10, 2025
I made a super dumb mistake last night and forgot to actually check if a revalidation was in progress 😅. Obviously immediately visible when adding tests. |
james-elicx
force-pushed
the
james/memory-queue
branch
from
7005134 to
95bb5be
Compare
james-elicx
commented
Feb 10, 2025
This reverts commit 42739ae.
james-elicx
force-pushed
the
james/memory-queue
branch
from
21c85f5 to
bc84f8b
Compare
james-elicx
force-pushed
the
james/memory-queue
branch
from
bc84f8b to
6256150
Compare
vicb
reviewed
Feb 11, 2025
vicb
reviewed
Feb 11, 2025
vicb
reviewed
Feb 11, 2025
vicb
reviewed
Feb 11, 2025
vicb
reviewed
Feb 11, 2025
vicb
reviewed
Feb 11, 2025
vicb
reviewed
Feb 11, 2025
vicb
reviewed
Feb 11, 2025
vicb
reviewed
Feb 11, 2025
vicb
approved these changes
Feb 11, 2025
vicb
approved these changes
Feb 12, 2025
|
Docs PR - opennextjs/docs#74 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Super basic de-duping on a per-isolate basis for the queue.
This approach uses the MessageGroupId for the de-duping key as it is based on just the path, and the key for ISR pages in the incremental cache is also the path, so we can compute the correct key to free from the list of revalidated paths.