-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KM plot show quantiles #93
Comments
Also allow to add horizontal line for median survival using a wrapper around geom_hline(yintercept=xx, linetype = xx) |
We used this as an "exercise to the reader" in the PSI2021 workshop, so we prepared a minimal solution for this. Just dropping this here as a starting point
|
@SHAESEN2 I'll probably have some time during R/Pharma 2021 to implement this, doesn't feel like a lot of work. Do you already have a name in mind? `add_survival_quantiles()' with "half" as the default? |
Unsorted ideas:
|
add_quantiles and make an S3 method out of it => add_quantiles uses get_quantiles. |
What do you think? The default behaviour is to pick linetype and colour separately for horizontal and vertical lines but are exposed as arguments accepting normal values.
|
I think I prefer a default of dotted lines. I asked @AlexandraP-21 to look into it as well. She has a good eye for those things. |
I took a look at the lines and like them dotted. However, I think that maybe (light) grey (and not black) would be better. The coloring ones I found them a bit confusing and distracting to be honest. Hope this helps! |
Add drop lines to show quantiles of the KM distribution.
The text was updated successfully, but these errors were encountered: