add_quantiles #288
Merged
add_quantiles #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
timtreis
added
enhancement
SHAESEN2
requested changes
Nov 2, 2021
SHAESEN2
requested changes
Nov 4, 2021
SHAESEN2
reviewed
Nov 5, 2021
SHAESEN2
reviewed
Nov 5, 2021
SHAESEN2
requested changes
Nov 19, 2021
|
Check is at 0/0/0, codecov at 100 % |
SHAESEN2
requested changes
Nov 20, 2021
|
Nice work. Some details pending :) |
- added more tests for visr survfit - updated visR to align with expectations - default method should not be a test. It should provide a default way of plotting objects
|
Hey @timtreis I have reviewed the branch. For me OK to merge now unless you have comments on my commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in #93
tagging @joanacmbarros since I can't tag her as a reviewer?