Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'thevalidatoR' gh-action to generate a report on the release #285

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

epijim
Copy link
Collaborator

@epijim epijim commented Oct 28, 2021

see https://github.com/marketplace/actions/r-package-validation-report

We added this to the Roche public repos - and one we share with GSK. It basically verbosely installs a package, describing the installation environment and process, and then unit tests, but traces unit tests back to documentation (e.g. maps requirements to testing).

@epijim epijim requested review from timtreis and SHAESEN2 October 28, 2021 17:29
@SHAESEN2
Copy link
Collaborator

It would be good to discuss the nice-to-have as well for the content of the report. There are still some key things missing eg when was the code updated vs the corresponding unit test. I would also categorize the tests per function etc ...

@epijim
Copy link
Collaborator Author

epijim commented Oct 29, 2021

@SHAESEN2 - we had a general discussion on the content here: insightsengineering/thevalidatoR#1

and from that populated issues. I want to ask about the purpose of the unit test vs code update timing, but maybe that's a better discussion over on the gh-action repo?

@timtreis timtreis merged commit e5a969c into develop Oct 29, 2021
@timtreis timtreis deleted the add/release-installation-validation branch October 29, 2021 08:52
@timtreis
Copy link
Collaborator

@SHAESEN2 I think you can't access that discussion from outside of Roche, I sent you a pdf

@SHAESEN2
Copy link
Collaborator

I can access the content. Thanks Tim. @epijim should I raise an issue in the repo? The purpose is to show that you wrote a test for the update that you did or at least looked if it was required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants