FIX - PRONOM sig update for Python 3 #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- open text files without binary option, e.g. `open(file, 'wb')` becomes `open(file'w')`; - added wrapper for old style list sorting method: `_cmp_to_key(mycmp)`; - rewrote `HTTPConnection` webservice calls in `fido/pronmutils.py` to work with Pyhton3 `http_client` library; - some gentle refactoring of monster `def run(defaults=None)` method in `fido/update_signatures.py`; and - tidied use of defaults in `fido/update_signatures.py`.
carlwilson
added
bug
|
Hi @ablwr I've tested this by running the update to PRONOM v95 via the |
ablwr
approved these changes
Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open(file, 'wb')becomesopen(file'w');_cmp_to_key(mycmp);HTTPConnectionwebservice calls infido/pronmutils.pyto work with Pyhton3http_clientlibrary;def run(defaults=None)method infido/update_signatures.py; andfido/update_signatures.py.