Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JHOVE 1.30 / PDF-hul 1.12.5 reports file as "Well-Formed and valid" despite PDF-HUL-2 error #924

Closed
asciim0 opened this issue May 23, 2024 · 1 comment · Fixed by #925
Closed

JHOVE 1.30 / PDF-hul 1.12.5 reports file as "Well-Formed and valid" despite PDF-HUL-2 error #924

asciim0 opened this issue May 23, 2024 · 1 comment · Fixed by #925
Labels
bug A product defect that needs fixing P1 High priority issues to be scheduled in the upcoming release
Milestone
JHOVE 1.32

Comments

@asciim0
Copy link
Contributor

asciim0 commented May 23, 2024

File to reproduce the issue is avail at https://www.schleswig-holstein.de/DE/landesregierung/ministerien-behoerden/VIII/Service/Broschueren/Broschueren_VIII/Kita/ArbeitshilfenSprachfoerderungElementarbereich.pdf?__blob=publicationFile&v=4 and atached here.

The behavior is as follows:
JHOVE 1.28.0 / PDF-hul 1.12.4 reported the file as "Well-Formed, but not valid" with a PDF-HUL-122 error at Offset 214251
JHOVE 1.30.0 RC1/ PDF-hul 1.12.5 reports the file as "Well-Formed and valid" with a PDF-HUL-2 error and no Offset

Could you advise whether either the PDF-HUL-2 error or the Well-formed and valid error in 1.30 are a false positive?

ArbeitshilfenSprachfoerderungElementarbereich.pdf
@samalloing
Copy link
Collaborator

Hi @asciim0,

My bad, I created a pull request for this

Thanks for spotting the mistake

Sam

@carlwilson carlwilson added this to the JHOVE 1.32 milestone Jul 11, 2024
@Ka-Markus Ka-Markus mentioned this issue Jul 18, 2024
Closed
carlwilson added a commit that referenced this issue Jul 31, 2024
@carlwilson
Merge pull request #925 from samalloing/samalloing-patch-3
3e7efb5 
fixes #924 by adding the invalid flag after adding a newly added Exception
@carlwilson carlwilson added bug A product defect that needs fixing P1 High priority issues to be scheduled in the upcoming release labels Aug 1, 2024
@carlwilson carlwilson linked a pull request Aug 1, 2024 that will close this issue
fixes #924 by adding the invalid flag after adding a newly added Exception #925
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A product defect that needs fixing P1 High priority issues to be scheduled in the upcoming release
Projects
None yet
Milestone
JHOVE 1.32
Development

Successfully merging a pull request may close this issue.

fixes #924 by adding the invalid flag after adding a newly added Exception
3 participants
@carlwilson @samalloing @asciim0