Feature Complete #115
Merged
Feature Complete #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix to make `ParseResultImpl.isRootName()` smarter; - dedicated and better tests for `Validator` class; and - tidied redundant tests in `ValidatorsTest`.
- better and tested instantiation for `MessageLogImpl`; - replaced naive `List` matches with `Stream` implementations; - tests and fixes for `MessageImpl` and `ValidationReport` `hashCode` and `equals`; and - improvements to OdfDocument tests.
Merge PR: Sent to main in error
TEST: Validator tests
TEST: Validator tests
- added new `org.openpreservation.odf.validation.Rule` interface for extended checks; - implemented `org.openpreservation.odf.validation.AbstractRule` class; - implemented `ODF_2` compliance test and reporting; - added `org.openpreservation.odf.validation.Rules` utility class; and - tidied `PackageParserTest` class.
- implemented package `mimetype` entry detection as `ODF_3` rule; - added null archive protection for `org.openpreservation.odf.pkg.OdfPackageImpl` methods; and - added `Rules` method to get `ODF_3`rule.
- implemented rule for extension and MIME type checking; - added `Rules` method for instantiation of rule; and - cleaned up unnecessary exceptions.
- added necessary Package methods to implement digital signature detection; - implemented digital signature detection for ODF_9 in `DigitalSignaturesRule`; and - added method to `Rules` for easy rule instantiation.
- swapped `MAN-1` and `MAN-4` so that the first matches the reporting in the spec.
- added rule to detect encrypted entries in manifest; - added method to FileEntry to flag encrypted files; - adjusted instantiation, hash code and equals methods of FileEntry to handle encryption flag; - added logic to manifest parser to parse encryption data;
- added a sub document detection rule for ODF_10; - added ODF_10 rule instantiation to `Rules`; and - added test for no package manifest to EncryptionRule.
FEAT: ODF_2 Compliance testing
FEAT: ODF_3 package mimetype entry
FEAT: ODF_4 Extension and MIME type
FEAT: ODF_9 Digital Signature detection
FIX: Align messages with draft specification
FEAT: ODF_1 Encryption
DOC: Added section on detection of specification issues.
FEAT: ODF_10 Sub Document detection
- added `SchematronRule` class to handle rules encoded as Schematron; - added schematron rules for for `ODF_5`, `ODF_7` and `ODF_8`; - added instatiation methods for `ODF_5`, `ODF_7` and `ODF_8` SchematronRules to `Rules`; - added prerequisite flag to `Rule` for profile sequencing; - working Hash and Equals for `AbstractRule`; - convenience method to get set of XML entries from `OdfPackage`; - convenience method to identify XML entries in `OdfPackages`; - tidied some compiler warnings, unused imports and the like; and - added schematron dependencies to `odf-core/pom.xml`.
- new `Profile` and `ProfileResult` classes for checking profiles; - refactoring to facilitated location reporting; - revamp of 'MessageLog` class with better methods; - improved filtering methods in `MessageLogImpl`; and - better methods for checking `ValidationReport` status.
- implemented DNA profile with pre-requisites and sequencing; and - tests for the above.
FEAT: Schematron profile rules
FEAT: Extended checking profiles
TEST: Unit tests for profile rules
FEAT: DNA Profile
- added option to invoke the profile validator; - fixed (hacked) console reporting to accomodate the change.
FEAT: CLI profile checking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.