REFACT: Tidied validator/profile calls #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- profile is now invoked after validation rather than as a branch in CLI; - added profiling via `ValidationReport` as half-way house before interface refactor; - added Rule checking via `ValidationReport` and provided a simple method in `AbstractProfile` that calls existing `validate` method; - improved some variable and method names;and - made some CLI methods static.
carlwilson
added a commit
that referenced
this pull request
Oct 16, 2024
* FEAT: Report blank namespaces (#187) - blank namespace prefixes are now reported as `<no-prefix>` in the `DOC-8` message`; - altered the `DOC-8` message to emphasise that prefixes are reported; - refactored out collection of namespaces into a Uitls class; and - removed trailing newline from `README` and template. * FIX: Pre-requisite handling (#188) - `POL-1` and `POL-2` are no longer pre-requisite rules, this means other policy rules will still run if these fail; - cleaned up a bug in pre-requisite handling where Validation reports weren't generated; - refactored the execution of Validation rules; and - removed a few unused imports. * REFACT: Tidied validator/profile calls (#189) * REFACT: Tidied validator/profile calls - profile is now invoked after validation rather than as a branch in CLI; - added profiling via `ValidationReport` as half-way house before interface refactor; - added Rule checking via `ValidationReport` and provided a simple method in `AbstractProfile` that calls existing `validate` method; - improved some variable and method names;and - made some CLI methods static. * FIX: Minor style issue. * REL: v0.14.0 (#190) - bumped Maven version to v0.14.0; - added updated versioned docs and README.md; and - udpdated Maven site and JavaDocs. * FIX: Pre-commit run. (#197) * REL: v0.14.0 - bumped Maven version to v0.14.0; - added updated versioned docs and README.md; and - udpdated Maven site and JavaDocs. * FIX: Pre-commit run.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValidationReportas half-way house before interface refactor;ValidationReportand provided a simple method inAbstractProfilethat calls existingvalidatemethod;