Paging details in listing responses #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d pretty formatting on result-list.json
|
I made a minor amendment to what the ticket (#21) said we should do, in that we specified that the parameters would be passed as an array of objects, but when implementing it seemed less verbose to make the parameters object essentially a string -> string map, so it's declared as a object with arbitrary keys and string values. I've also used "patternProperties", which seems fine in JSON schema, but I've been struggling to get the OpenAPI spec to validate (quite a few tools seem to not like 3.1.0) or to generate the HTML, so I'm not 100% sure that that is as well supported in the API spec. |
carlwilson
reviewed
May 9, 2024
carlwilson
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Issue #21