-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow methods to use de_train_h5ad
instead of de_train
.
#14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We get an error in
def set_par_values(config) -> None:
due to the resources path based on par argument that isn't necessary.
❯ ./scripts/add_a_method.sh
[warning] --task looks like a parameter but is not a defined parameter and will instead be treated as a positional argument. Use --help to get more information on the parameters.
Check inputs
Check language
Check API file
Read API file
Create output dir
Create config
Create script
Traceback (most recent call last):
File "/viash_automount/var/folders/98/9ygjwkpd12d1vxydfprn1st00000gp/T//viash-run-create_component-CTkCHC.py", line 358, in <module>
main(par)
File "/viash_automount/var/folders/98/9ygjwkpd12d1vxydfprn1st00000gp/T//viash-run-create_component-CTkCHC.py", line 342, in main
set_par_values(api)
File "/viash_automount/var/folders/98/9ygjwkpd12d1vxydfprn1st00000gp/T//viash-run-create_component-CTkCHC.py", line 194, in set_par_values
value = f'resources_test/{par["task"]}/pancreas/{key_strip}.h5ad'
KeyError: 'task'
Files and logs are stored at '/tmp/viash_create_component12384494734812512647'
for the issue in I think we could replace with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rcannood could you please confirm whether that removal is ok?
after the 2 small changes I commented on above, lgtm! |
Describe your changes
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!