Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow info.test_default in arguments #21

Merged
merged 1 commit into from
May 9, 2024
Merged

allow info.test_default in arguments #21

merged 1 commit into from
May 9, 2024

Conversation

rcannood
Copy link
Member

@rcannood rcannood commented May 9, 2024

Describe your changes

This PR changes the unit test to look at the .info.test_default field inside an argument. This allows a component to have an argument like this:

arguments:
  - type: integer
    name: --epochs
    default: 100
    info:
      test_default: 3

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality (new method, new metric, ...)
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@rcannood rcannood requested a review from szalata May 9, 2024 13:25
@rcannood rcannood merged commit c0c64e7 into main May 9, 2024
20 checks passed
@rcannood rcannood deleted the test_defaults branch May 11, 2024 07:53
szalata pushed a commit that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant