-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up metrics #59
Clean up metrics #59
Conversation
I would rather make all of the metrics (or have a component that clips the input) clip, to avoid the potential issue of penalizing methods that may still predict values beyond the threshold. |
Just to make a note of this: We decided to clip the input values of the
If there was less of an imbalance between abs(sign_log10_pval) < 1 and >= 1, the effects would be more pronounced. |
Describe your changes
clipped_sign_log10_pval
layer to the kaggle datasetclipped_sign_log10_pval
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!