Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the bootstrapping component to align with what one expects from a bootstrapping method #61

Merged
merged 1 commit into from
Jun 2, 2024
Merged

fix the bootstrapping component to align with what one expects from a bootstrapping method #61

merged 1 commit into from
Jun 2, 2024

Conversation

rcannood
Copy link
Member

@rcannood rcannood commented Jun 2, 2024 •
edited
Loading

Describe your changes

  • Remove the previous bootstrap de_train & de_test component
  • Adjust bootstrapping strategy to align with what is commonly understood as bootstrapping

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality (new method, new metric, ...)
    • Major changes
    • Minor changes
    • Bug fixes

  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@rcannood rcannood requested a review from szalata June 2, 2024 15:59
@rcannood rcannood merged commit 02d3dff into main Jun 2, 2024
6 checks passed
@rcannood rcannood deleted the fix_bootstrapping branch June 2, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szalata szalata Awaiting requested review from szalata

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rcannood