Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cpa #78

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add cpa #78

wants to merge 10 commits into from

Conversation

szalata
Copy link
Collaborator

@szalata szalata commented Oct 17, 2024

Describe your changes

This code adds the cpa method. It is a major change since the method operates on single-cell data and outputs an h5ad that contains single-cell data and will have to be pseudobulked and run through limma to get the final output. I limited this PR to CPA, but I'd appreciate your ideas on how to best integrate it into run_benchmark.

Also, since this would take a while to run, it would be great if you could try to run it in any way possible on AWS, so that I can at least use the output to generate a plot or table to the camera ready version (all of the remaining steps should be easy enough for me to run locally)

A primary issue with this code is that since I cannot run docker on our cluster, I cannot test it on a similar environment to AWS.

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@szalata szalata requested a review from rcannood October 17, 2024 18:40
@szalata szalata closed this Oct 29, 2024
@rcannood rcannood reopened this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants