Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD: Add binder files for LROSE #5

Merged
merged 3 commits into from
Jun 24, 2024
Merged

ADD: Add binder files for LROSE #5

merged 3 commits into from
Jun 24, 2024

Conversation

mgrover1
Copy link
Contributor

@mgrover1 mgrover1 commented May 6, 2024

Add initial binder build with LROSE

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024 •
edited
Loading

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 9d44322
✅ Deployment Preview URL: https://openradar.github.io/erad2024/_preview/5

@mgrover1 mgrover1 requested a review from kmuehlbauer May 6, 2024 20:18
@kmuehlbauer
Copy link
Collaborator

@mgrover1 Should we change here to execute with binder? Or should we add another CI run?

erad2024/_config.yml

Lines 10 to 11 in 9388f01

# To execute notebooks via a Binder instead, replace 'cache' with 'binder'
execute_notebooks: cache

@mgrover1
Copy link
Contributor Author

mgrover1 commented May 8, 2024

Great question @kmuehlbauer - let's execute with binder..

leavesntwigs
leavesntwigs approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@leavesntwigs leavesntwigs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LROSE binary for installation looks good, and I also see /usr/local/bin in the path.
Thanks! Max.

@mgrover1 mgrover1 merged commit 3940dc6 into openradar:main Jun 24, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 24, 2024
@mgrover1 @github-actions
Delete preview for pull request \#5
235e6c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leavesntwigs leavesntwigs leavesntwigs approved these changes

@kmuehlbauer kmuehlbauer Awaiting requested review from kmuehlbauer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgrover1 @kmuehlbauer @leavesntwigs