Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: PyDDA Wind retrieval notebook and baltrad2wradlib notebook #71

Merged
merged 6 commits into from
Aug 15, 2024

Conversation

kmuehlbauer
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Aug 14, 2024

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: ce87336
✅ Deployment Preview URL: https://openradar.github.io/erad2024/_preview/71

@kmuehlbauer
Copy link
Collaborator Author

If this runs through and the preview is OK, I'm going to merge this later today.

@mgrover1
Copy link
Contributor

@kmuehlbauer - can you add the following to the environment file as well? This will help the pydda notebook:

  - jaxopt
  - tensorflow>=2.6
  - tensorflow-probability

This will likely speed up the execution of the pydda notebooks as well.

@kmuehlbauer
Copy link
Collaborator Author

Is this available in conda-forge?

@mgrover1
Copy link
Contributor

yep! 👍

@mgrover1
Copy link
Contributor

@kmuehlbauer
Copy link
Collaborator Author

I've had to revert the tensorflow addition. The environment did not resolve. Maybe we need to create two (or more) different environments?

@kmuehlbauer kmuehlbauer merged commit 60bd8d3 into openradar:main Aug 15, 2024
2 checks passed
@kmuehlbauer kmuehlbauer deleted the fix-notebooks branch August 15, 2024 04:50
github-actions bot pushed a commit that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants