Replace/Remove links to private Google Docs in Changelog page #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HSDS Changelog headers attempt to link off to further information surrounding the release of that version. However, versions 1.0 downwards linked off to private google docs. HSDS has only been semi-consistent in creating releases on Github for versions. Some version headers link to issue queries filtered by milestones. This is acceptable where no release exists, however others link off to private, non-public, Google docs. I have replaced the 1.0 link to the official GH release link, and removed the others for which there is no milestone, label, or release tag. This means that for versions `0.x` down, there are currently no header links. Links to the GDocs remain in the body of the changelog for that version. In the future, if these details are pulled through onto a public page or backported into Github; we can modify the headings with new links.
|
Thanks. The first couple of versions were managed in Google Docs. should we reclaim that content from the docs for historical purposes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Description
The HSDS Changelog headers attempt to link off to further information surrounding the release of that version. However, versions 1.0 downwards linked off to private google docs.
HSDS has only been semi-consistent in creating releases on Github for versions. Some version headers link to issue queries filtered by milestones. This is acceptable where no release exists, however others link off to private, non-public, Google docs.
I have replaced the 1.0 link to the official GH release link, and removed the others for which there is no milestone, label, or release tag.
This means that for versions
0.xdown, there are currently no header links. Links to the GDocs remain in the body of the changelog for that version. In the future, if these details are pulled through onto a public page or backported into Github; we can modify the headings with new links.Merge checklist
If you have edited any schema files:
hsds_schema.pyto updatedatapackage.jsonand example files