feature: add balancer_ssl_session_fetchby and balancer_ssl_session_storeby #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongbeiouba
changed the title
dongbeiouba
changed the title
|
Are there any plans to pick up this work? Was debugging SSL induced performance issues when I verified this behavior (and later found this ticket). |
|
@spacewander @rainingmaster please help to take a look at this PR, thanks :) |
|
This pull request is now in conflict :( |
|
@spacewander @rainingmaster Any help in integrating this PR would be much appreciated. |
zhuizhuhaomeng
force-pushed
the
master
branch
from
f924579
to
fef2581
Compare
|
This pull request is now in conflict :( |
|
This pull request is now in conflict :( |
|
This pull request is now in conflict :( |
|
This pull request is now in conflict :( |
|
This pull request is now in conflict :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.
Nginx support caching and reusing the upstream ssl session, but balancer_by_lua don't support reusing the ssl session.
So i add the hook balancer_ssl_session_fetchby and balancer_ssl_session_storeby; and then we can cache the ssl session with lua code.
Cache and reuse the ssl session can reduce ssl full handshake with the proxied servers; especially for those nginx which not config keepalive.