bugfix: let balancer.recreate_request API work for body data changed case
#2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oowl
changed the title
|
From https://github.com/openresty/lua-resty-core/blob/master/lib/ngx/balancer.md#recreate_request, |
oowl
changed the title
oowl
changed the title
balancer.recreate_request API work for body data changed case
zhuizhuhaomeng
previously approved these changes
Jul 11, 2024
|
@oowl please add a test case to cover this bug. |
|
@zhuizhuhaomeng CI is flaky, I am not sure why the plan number is not stable in our Perl test. |
zhuizhuhaomeng
approved these changes
Jul 12, 2024
3 tasks
fffonion
pushed a commit
to Kong/kong
that referenced
this pull request
Sep 12, 2024
…ffer (#13377) issue when ngx.req.set_body_data is used in balancer phase backport Openresty upstream fix: openresty/lua-nginx-module#2334 issues context: openresty/lua-nginx-module#2333 AG-12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.
Context: #2333