Add access_by_lua(_block/_file) and access_by_lua_no_postpone #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcivanov
force-pushed
the
access_by_lua
branch
2 times, most recently
from
42a195d
to
7b9c916
Compare
deba12
reviewed
Nov 9, 2020
arcivanov
force-pushed
the
access_by_lua
branch
from
f17c4cb
to
eeca371
Compare
1 similar comment
|
This would also be useful for me since I want to resolve a name to be used in |
1 similar comment
arcivanov
force-pushed
the
access_by_lua
branch
from
eeca371
to
96c8681
Compare
|
@arcivanov Got it, I'll look into it. |
spacewander
reviewed
Jul 16, 2021
| @@ -28,13 +28,14 @@ init | |||
|
|
|||
|
|
|||
| === TEST 2: get_phase in access_by_lua | |||
| TODO | |||
| --- SKIP | |||
| --- stream_server_config | |||
| access_by_lua_block { | |||
There was a problem hiding this comment.
Can we add a test that using both preread and access phases?
Does the access phase have the limitation below in the preread phase?
However, keep in mind that calling the receive() method of the request socket will consume the data from the buffer and such consumed data will not be seen by handlers further down the chain.
Some rudimentary tests Requested cleanup of `#if 1` Try fixing tests
arcivanov
force-pushed
the
access_by_lua
branch
from
35e4088
to
0e2e7b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some rudimentary tests