-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/SAC console - remove hardcoded role names #1947
Conversation
@enrubio I think this pr require more tests |
that would be great, thanks Xukun! |
please take a look at the changes in #1924 before you make the change here |
Oohh okay I'll check. I also noticed as an AC sending messages to PCs (SACs to Reviewers), the message modal correctly shows the number of emails and who they're sent to. But this was an issue in #1924 for some reason, so maybe an API change is not needed? What do you think @xkopenreview? |
@xkopenreview Discussed with @melisabok and decided that the SAC console tests will be added in a separate PR. Right now the plan is to:
|
for those in the missingConfig of sac console if they are missing the sac console will not load and the menu bar won't be displayed for the rest i think default value should be added to all sub components where it's used |
I didn't end up adding any fields to the missingconfigs of the SAC or PC console, but I removed |
i think it will be clearer when pc console is also changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like everything is working as expected.
this pr should remove hardcoded role names from sac console