-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ Workflow invitations #1952
base: master
Are you sure you want to change the base?
Conversation
edit.content.note_content of submission form invitation has type "content" |
It supports a JSON type following the content schema, the UI should render the code editor like we do in the invitation editor. |
i think showing existing value in workflow invitation (and invitation editor) may not work as expected because of the mismatch of the field name in workflow invitation and the content field name in sub invitations. currently it's looking for the sub invitation content field name in all fields of sub invitation and use the first match as the path in workflow invitation however if the sub invitation's content field is used in multiple $ notation or the $ notation is combined/modified instead of a simple copy, the "existing value" is not clear |
let's discuss it in a call. |
…oups, and display them in the UI
e5ca7b1 contains changes for :
|
5ee3c32 contains changes for:
|
feffaea contains the following changes:
|
@celestemartinez
|
cd98c0d contains the following changes:
|
I have started hardcoding some of the workflow invitations we have so we can have an idea what this will look like.
I tried using
PaginatedList
but I am not sure how to make it work with the indented "sub-invitations". This is what it looks like now:The
Edit
link should actually open a form that shows the fields that can be edited.To check, you can run the
test_venue_configuration.py
test here: openreview/openreview-py#2118