Fix/ Invitation revisions page - edit to remove process function is not displayed correctly #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xkopenreview
commented
Sep 26, 2024
| @@ -23,7 +23,7 @@ const GroupUICode = ({ group, profileId, accessToken, reloadGroup }) => { | |||
| const requestBody = { | |||
| group: { | |||
| id: group.id, | |||
| web: modifiedWebCode.trim() ? modifiedWebCode.trim() : null, | |||
| web: modifiedWebCode, | |||
There was a problem hiding this comment.
not to convert space to empty string because empty string is not allowed
to make it consistent with invitation editor
carlosmondra
approved these changes
Sep 26, 2024
enrubio
reviewed
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires some discussion about removing process/web from invitation and group
discussed with Carlos
for now the way to delete webfield/process function is to pass space