Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional steps to Log4j1ToLog4j2 #195

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Add additional steps to Log4j1ToLog4j2 #195

merged 4 commits into from
Dec 3, 2024

Conversation

timtebeek
Copy link
Contributor

@timtebeek timtebeek commented Dec 3, 2024 •
edited
Loading

@timtebeek timtebeek self-assigned this Dec 3, 2024
@timtebeek timtebeek added the recipe Recipe Requested label Dec 3, 2024
@timtebeek timtebeek marked this pull request as ready for review December 3, 2024 22:38
@timtebeek timtebeek mentioned this pull request Dec 3, 2024
Closed
github-actions[bot]
github-actions bot reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/test/java/org/openrewrite/java/logging/log4j/Log4j1ToLog4j2Test.java
    • lines 18-18

github-actions[bot]
github-actions bot reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/test/java/org/openrewrite/java/logging/log4j/Log4j1ToLog4j2Test.java
    • lines 18-18

@timtebeek timtebeek merged commit 976a272 into main Dec 3, 2024
1 of 2 checks passed
@timtebeek timtebeek deleted the additional-log4j1-to-log4j2-steps branch December 3, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@timtebeek timtebeek

Labels
recipe Recipe Requested
Projects
OpenRewrite
Archived in project
Milestone
No milestone
1 participant
@timtebeek