Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove public modifier from integration tests classes #496

Closed
khmarbaise opened this issue Feb 6, 2023 · 2 comments · Fixed by #498
Closed

Remove public modifier from integration tests classes #496

khmarbaise opened this issue Feb 6, 2023 · 2 comments · Fixed by #498
Labels
enhancement New feature or request
Milestone
4.40.0

Comments

@khmarbaise
Copy link
Contributor

Currently all integration tests are defined like:

..
public class BasicIT {
..
}

which is not necessary.
khmarbaise added a commit to khmarbaise/rewrite-maven-plugin that referenced this issue Feb 6, 2023
@khmarbaise
fix Remove public modifier from integration tests classes (openrewrit…
2fca019 
…e#496)

 * remove also unused class TimeUtils.
@timtebeek
Copy link
Contributor

That's embarrassing; we even have a recipe for that; let me see if I can run that quickly. :)

@timtebeek timtebeek added the enhancement New feature or request label Feb 6, 2023
@timtebeek timtebeek moved this to Backlog in OpenRewrite Feb 6, 2023
timtebeek added a commit that referenced this issue Feb 6, 2023
@timtebeek @TeamModerne
refactor: Remove public visibility of JUnit 5 tests
9f90cf1 
Partial fix for #496

Co-authored-by: Moderne <team@moderne.io>
@timtebeek timtebeek mentioned this issue Feb 6, 2023
Merged
timtebeek added a commit that referenced this issue Feb 6, 2023
@timtebeek @TeamModerne
Remove public visibility of JUnit 5 tests (#498)
3cff0f5 
* refactor: Remove `public` visibility of JUnit 5 tests

Partial fix for #496

Co-authored-by: Moderne <team@moderne.io>

* Remove public modifier from IT classes

Also remove unused imports

* Restore DiscoverNoActiveRecipeIT after failed local merge

---------

Co-authored-by: Moderne <team@moderne.io>
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenRewrite Feb 6, 2023
@timtebeek
Copy link
Contributor

Thanks again! We have a plan internally to apply our recipes to our own code continuously; thanks for the reminder to move that up in priority!

timtebeek pushed a commit that referenced this issue Feb 7, 2023
@khmarbaise
fix Remove public modifier from integration tests classes (#496) (#497)
1ed5285 
* remove also unused class TimeUtils.
@timtebeek timtebeek added this to the 4.40.0 milestone Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
OpenRewrite
Archived in project
Milestone
4.40.0
Development

Successfully merging a pull request may close this issue.

Remove public visibility of JUnit 5 tests openrewrite/rewrite-maven-plugin
2 participants
@khmarbaise @timtebeek