-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse SPI configuration files as PlainText
#344
Conversation
…ecipes to run agaianst them
After talking it over with the team, we felt we needed a better, generalized solution to handling "files that are known to exist but are not formally parsed by one of rewrite's parser". The problem with using the PlainText parser to scoop up everything that is left over is that it will likely encounter binary files that would result in exceptions when attempting to use a character encoding. I am going to close this PR but know that your input resulted in a "new type of file that exists but cannot be seen". 8) We landed on "quark" because we are all nerds. We will prioritize this into our backlog and try to get this work done soon. Thanks again! |
@m-brophy Just want to provide a follow-up on this. In We'll update I would appreciate this PR still, but slightly modified -- I'd still like to parse these particular files as |
Quarks give us the ability to see everything that isn't parsed, but let's still parse |
PlainText
…ecipes to run against them.
The purpose of this is to enable the running of recipe org.openrewrite.RenameFile against bootstrapping files in a javax-jakarta migration like so:
I don't know if you think it necessary to restrict the files found by the accept method of PlainTextParser but that could be achieved for my purposes by adding any files in path resources/META-INF/services as well as files with appropriate extensions.