Pass in single recipe configuration options on the command line

[velo]

• Possible fix for Pass arguments from the command line into a single configurable recipe #799

Use like this:

mvn org.openrewrite.maven:rewrite-maven-plugin:5.36.0-SNAPSHOT:run \
  -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-migrate-java:RELEASE \
  -Drewrite.activeRecipes=org.openrewrite.java.migrate.util.ReplaceStreamCollectWithToList  \
  -Drewrite.options=convertToList=true

[timtebeek]

Thanks for getting this started! Would you happen to have an example of how the non-flat Map is assigned from the command line? I'm wondering how to test this properly. We'll likely start with incubating this, and potentially have to limit it to non-composite recipes, as larger composites can contain a single recipe multiple times, and not all recipes might have the same options. Right now it seems like we might set the same argument on all recipes?

[velo]

From command line it wouldn't be possible, as maven don't parse complex types from command line.

Those can only be set as maven configuration on pom file

<options>
  <convertToList>true</convertToList>
</options>

[timtebeek]

Nice to see this kicked off ; I've added two comments that I think we should address before a merge, but I'm also interested to hear your thoughts. Mostly I want to add this in such a way that we promote good practices, and not enable anti-patterns too much.

[timtebeek]

I've gone ahead and applied the changes I suggested earlier @velo ; Hope you agree with the final form. I'll likely merge this tomorrow morning unless any blocking feedback comes in.

[timtebeek]

This now works.

mvn org.openrewrite.maven:rewrite-maven-plugin:5.36.0-SNAPSHOT:run -Drewrite.activeRecipes=org.openrewrite.maven.RemovePlugin -Drewrite.options=groupId=org.springframework.boot,artifactId=spring-boot-maven-plugin

When run against the spring-petclinic it correctly removes only the argument plugin;
When a second recipe is activated, or a required option missing, we reject the recipe run.

Thanks to all involved!

[velo]

This is awesome... I'm still shocked that maven can parse lists but can't maps

[timtebeek]

Thanks again @velo ! Hope this helps folks to do quick one-off configurable recipe runs.