Add rewrite-java-21 to support parsing Java 21+ projects #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
changed the title
|
@knutwannheden would you happen to know if not adding rewrite-java-21 here and in the Gradle plugin was an oversight or intentional? |
pstreef
approved these changes
Oct 1, 2024
This was referenced Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's your motivation?
Anyone you would like to review specifically?
I've not had time to test this according to the steps outlined in openrewrite/rewrite#4534, hoping @triceo is willing to give this a try.
Have you considered any alternatives or workarounds?
We could have tried again to build on Java 21, as seen in 800bc01, but decided against that following #690 .
There have been previous attempts:
Invalid parameter name ""when running on Java 8 rewrite#3826