Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta EE Upgrade Recipe Cleanup #444

Merged
merged 5 commits into from
Apr 22, 2024
Merged

Jakarta EE Upgrade Recipe Cleanup #444

merged 5 commits into from
Apr 22, 2024

Conversation

Mistborn94
Copy link
Contributor

What's changed?

  • Replace Add/Remove Dependency pairs in Jakarta EE recipes with ChangeDependency
  • Add upgrades for jakarta platform dependencies that were missing

What's your motivation?

@Mistborn94 Mistborn94 changed the title Jakarta EE Recipe Cleanup Jakarta EE Upgrade Recipe Cleanup Mar 26, 2024
@Mistborn94
Copy link
Contributor Author

@timtebeek Can I get a review here maybe?

@timtebeek
Copy link
Contributor

Hi yes sure! I've been out on holiday for the past couple weeks, hence why it's taken a bit longer to get to a review. This week and next I'm still traveling for conferences, but I'll see what I can fit in or delegate. Either way thanks for these changes already!

@timtebeek timtebeek requested a review from ranuradh April 11, 2024 11:04
@timtebeek timtebeek added the bug Something isn't working label Apr 11, 2024
@timtebeek timtebeek self-requested a review April 14, 2024 19:34
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for going through and replacing all these outdated add/remove patterns with change dependency. That should help improve stability of these migrations, as well as minimize the diff to in-place replacements, instead of disconnected add/removes. Great improvement!

@timtebeek timtebeek merged commit 6920ea6 into openrewrite:main Apr 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
2 participants