jacoco upgrade now includes arbitrary jacoco deps (eg agent), always …

[nmck257]

…sends to highest patch version, and happens in the java 6 recipe (and therefore runs at every java upgrade)

What's changed?

see title

What's your motivation?

• apps using offline instrumentation may also have the jacoco agent in their dependencies
• pretty much any java upgrade might require a jacoco upgrade, depending on the initial version, and the current recipes only touched jacoco at certain versions

Anything in particular you'd like reviewers to focus on?

the test file has a reference to "latest jacoco version" which would need to be maintained over time for the tests to pass; I forget if we have a tidier pattern for cases like this

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[timtebeek]

Very quickly saving folks a quick if they get to this before I do

UpgradeToJava6Test > dataSource() FAILED
    java.lang.AssertionError: [Recipe validation must have no failures] 
    Expecting no elements of:
      [[Valid{property='initialization', value='org.openrewrite.config.DeclarativeRecipe@c746f615'},
        Valid{property='initialization', value='org.openrewrite.config.DeclarativeRecipe@c746f615'},
        Valid{property='initialization', value='org.openrewrite.config.DeclarativeRecipe@d1528c9'},
        Invalid{property='org.openrewrite.java.migrate.JREWrapperInterface.recipeList[0] (in rewrite.yml)', value='org.openrewrite.java.migrate.jacoco.UpgradeJaCoCo', message='recipe 'org.openrewrite.java.migrate.jacoco.UpgradeJaCoCo' does not exist.'},

[nmck257]

whoops, fixed - thanks!

[timtebeek]

Thanks a lot! Cleaner indeed to have it all in one place. I didn't know JaCoCo is so strongly backwards compatible to older Java version; that sure makes this easier.

[nmck257]

Sure thing, thanks for adjusting the test case to avoid the hardcoded version!

[timtebeek]

Sure thing, thanks for adjusting the test case to avoid the hardcoded version!

Yeah just saving future me some time down the road. :) Didn't want to trouble you for it.