Remove Jakarta annotation dependency when moving to Jakarta packages

[abccbaandy]

What's changed?

Add a recipe to revert the jakarta.annotation-api added by org.openrewrite.java.migrate.javax.AddCommonAnnotationsDependencies

What's your motivation?

Fix #481

• jakarta.annotation-api dependency added in Java 11 migration should be removed when migrating to Jakarta  #481

Anyone you would like to review specifically?

@timtebeek

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[timtebeek]

Preconditions are the typical way to limit what files recipes operate on. That would look something like this

Suggested change

	recipeList:
	- org.openrewrite.java.dependencies.DependencyInsight:
	groupIdPattern: jakarta.annotation
	artifactIdPattern: jakarta.annotation-api
	preconditions:
	- org.openrewrite.java.dependencies.DependencyInsight:
	groupIdPattern: jakarta.annotation
	artifactIdPattern: jakarta.annotation-api
	recipeList:

I'm not sure about the use of DependencyInsight here though, as we likely only want to remove the dependency if it's already available transitively. That might need some custom logic. 🤔

[abccbaandy]

Yes, not just found.
We need find in transitively "only", is this possible with DependencyInsight?

[timtebeek]

Not right now; we do have an onlyDirect option on that recipe, but perhaps we'd need to add an onlyTransitive:
https://docs.openrewrite.org/recipes/maven/search/dependencyinsight#dependencies-in-use

[abccbaandy]

I see, guess we can only postpone this PR until DependencyInsight support onlyTransitive? 😢

[timtebeek]

Possibly yes. Although that might not be too difficult as we already know the depth there, since we add that to the data table we produce.

[abccbaandy]

How?
Just like my comment 1. said, it's gone.

I can submit PR with the failed test if you want.

[abccbaandy]

I check if contain spring boot starter instead, because this.
I think this PR is done now if no other better way.

[timtebeek]

Thanks a lot for restoring this functionality. Should be good to see the jakarta annotation removed in the common case of using a spring-boot-starter.

[abccbaandy]

@timtebeek
Just curious, when can we test this in latest version?

[timtebeek]

Hi! It's not yet I'm the latest release, but should be in the latest snapshot version. We release every two weeks. Hope that helps!