Delete deprecated finalize #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hods in java.desktop Module
timtebeek
reviewed
Jul 3, 2024
src/test/java/org/openrewrite/java/migrate/DeleteDeprecatedFinalizeTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/migrate/DeleteDeprecatedFinalizeTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/migrate/DeleteDeprecatedFinalizeTest.java
Show resolved
Hide resolved
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/test/java/org/openrewrite/java/migrate/DeleteDeprecatedFinalizeTest.java
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/migrate/DeleteDeprecatedFinalizeTest.java
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/migrate/DeleteDeprecatedFinalizeTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
src/test/java/org/openrewrite/java/migrate/DeleteDeprecatedFinalizeTest.java
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/migrate/DeleteDeprecatedFinalizeTest.java
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/migrate/DeleteDeprecatedFinalizeTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
timtebeek
approved these changes
Jul 3, 2024
src/test/java/org/openrewrite/java/migrate/DeleteDeprecatedFinalizeTest.java
Show resolved
Hide resolved
|
|
||
| import static org.openrewrite.java.Assertions.java; | ||
|
|
||
| public class DeleteDeprecatedFinalizeTest implements RewriteTest { |
There was a problem hiding this comment.
Suggested change
| public class DeleteDeprecatedFinalizeTest implements RewriteTest { | |
| class DeleteDeprecatedFinalizeTest implements RewriteTest { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
The java.desktop module had a few implementations of finalize() that did nothing and has been removed.
What's your motivation?
Remove empty finalize() methods in java.desktop module
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist