Adding all org.glassfish.main migrations to jakarta #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
reviewed
Jul 26, 2024
There was a problem hiding this comment.
Great to see, thanks! Couple of quick questions as I went over the artifactIds; if you could answer those I think we can merge soon after.
For Yaml only recipes it's not always necessary to write a test; in some cases that might bring to light dependencies that can't be found, as might have been the case here. No need to add them now I'd say.
Co-authored-by: Tim te Beek <timtebeek@gmail.com>
timtebeek
approved these changes
Jul 29, 2024
|
Thanks for your help! However, I did an oopsie by thinking your thumbs-up in the discussion for org.glassfish:jakarta.faces meant that I should re-add the migration with another target. I think we should revert commit 124cb01 to re-delete the jsf migration. |
timtebeek
added a commit
that referenced
this pull request
Jul 29, 2024
As discussed on #517 (comment)
|
Thanks! Dropped now in 61ed4bc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Added migrations for all Java EE APIs under the organization org.glassfish.main. Added a migration for java.ejb:javax.ejb to jakarta.ejb. These changes are implemented in the org.openrewrite.java.migrate.jakarta.JavaxMigrationToJakarta Recipe.
What's your motivation?
https://rewriteoss.slack.com/archives/C01A843MWG5/p1721228381110469
Any additional context
Should I implement tests for each case? As far as I see the other migrations of this recipe don't have tests and I'm not sure what for I would be testing other than typos anyways.
Checklist