-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1/x] Implement joda to java time migration recipe #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/org/openrewrite/java/migrate/joda/JodaTimeVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/joda/templates/DateTimeFormatTemplates.java
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/joda/templates/DateTimeTemplates.java
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/joda/templates/DurationTemplates.java
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/joda/templates/MethodTemplate.java
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/joda/templates/TimeZoneTemplates.java
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/joda/templates/TimeZoneTemplates.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/migrate/joda/JodaTimeVisitorTest.java
Show resolved
Hide resolved
import static org.openrewrite.java.Assertions.java; | ||
import static org.openrewrite.test.RewriteTest.toRecipe; | ||
|
||
public class JodaTimeVisitorTest implements RewriteTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
public class JodaTimeVisitorTest implements RewriteTest { | |
class JodaTimeVisitorTest implements RewriteTest { |
src/test/java/org/openrewrite/java/migrate/joda/JodaTimeVisitorTest.java
Show resolved
Hide resolved
…r.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
src/main/java/org/openrewrite/java/migrate/joda/JodaTimeVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/joda/templates/DateTimeFormatTemplates.java
Show resolved
Hide resolved
Comment on lines
24
to
26
import static org.openrewrite.java.migrate.joda.templates.TimeClassNames.JAVA_ZONE_ID; | ||
import static org.openrewrite.java.migrate.joda.templates.TimeClassNames.JAVA_ZONE_OFFSET; | ||
import static org.openrewrite.java.migrate.joda.templates.TimeClassNames.JODA_DATE_TIME_ZONE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
import static org.openrewrite.java.migrate.joda.templates.TimeClassNames.JAVA_ZONE_ID; | |
import static org.openrewrite.java.migrate.joda.templates.TimeClassNames.JAVA_ZONE_OFFSET; | |
import static org.openrewrite.java.migrate.joda.templates.TimeClassNames.JODA_DATE_TIME_ZONE; | |
import static org.openrewrite.java.migrate.joda.templates.TimeClassNames.*; |
src/test/java/org/openrewrite/java/migrate/joda/JodaTimeVisitorTest.java
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/migrate/joda/JodaTimeVisitorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/migrate/joda/JodaTimeVisitorTest.java
Show resolved
Hide resolved
…r.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…TimeFormatTemplates.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…TimeFormatTemplates.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…tionTemplates.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…TimeTemplates.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…odTemplate.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ClassNames.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ZoneTemplates.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ZoneTemplates.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…rTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…rTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…rTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…rTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…rTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
This pr is the first part of implementing the migration from Joda-Time to the Java Time API. The focus of this PR is to introduce templates for migrating key methods within the DateTime class and other related classes from Joda-Time to Java Time.
Key Changes:
Not Implemented Yet:
Migrations for expressions referencing variables of Joda-Time types are currently skipped. The logic to migrate variables and expressions referencing Joda-Time classes will be added in a follow-up PR.
Checklist