Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Spring annotations to JSpecify #572

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Oct 7, 2024

What's changed?

add Spring Annotations migration recipe to jspecify.yml

What's your motivation?

image

Anything in particular you'd like reviewers to focus on?

n/a

Anyone you would like to review specifically?

n/a

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@sullis sullis changed the title migrate Spring annotations to Jspecify WIP migrate Spring annotations to Jspecify Oct 7, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/org/openrewrite/java/migrate/util/MigrateCollectionsSingletonList.java
    • lines 18-19

@sullis sullis changed the title WIP migrate Spring annotations to Jspecify migrate Spring annotations to Jspecify Oct 8, 2024
@sullis sullis marked this pull request as ready for review October 8, 2024 03:35
@sullis sullis changed the title migrate Spring annotations to Jspecify migrate Spring annotations to JSpecify Oct 8, 2024
@timtebeek timtebeek self-requested a review October 8, 2024 11:09
@timtebeek timtebeek added the recipe Recipe requested label Oct 8, 2024
@timtebeek timtebeek changed the title migrate Spring annotations to JSpecify Migrate Spring annotations to JSpecify Oct 9, 2024
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for immediately testing the nested case as well. :)

@timtebeek timtebeek merged commit 44d79d2 into openrewrite:main Oct 9, 2024
2 checks passed
@sullis sullis deleted the sean/jspecify-spring-annotations branch October 9, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
recipe Recipe requested
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants