-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not convert return types in NoGuavaJava21 by default #601
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/main/java/org/openrewrite/java/migrate/guava/AbstractNoGuavaImmutableOf.java
- lines 19-19
hi @BramliAK ; Understand that you'd like this fixed; Instead of completely removing this, can we make this opt-in with an |
src/main/java/org/openrewrite/java/migrate/guava/AbstractNoGuavaImmutableOf.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/guava/AbstractNoGuavaImmutableOf.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/guava/AbstractNoGuavaImmutableOf.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/guava/AbstractNoGuavaImmutableOf.java
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
src/main/java/org/openrewrite/java/migrate/guava/AbstractNoGuavaImmutableOf.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/guava/AbstractNoGuavaImmutableOf.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BramliAK ! Good to be back to stable recipe outputs by default, while still being able to do the unsafe migrations if desired.
What's changed?
Rollback visit Variable Declarations
Checklist