Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent breakage of usages of Spring's @Nullable #602

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Conversation

kmccarp
Copy link
Contributor

@kmccarp kmccarp commented Nov 13, 2024

What's changed?

I commented out the migration from @org.springframework.lang.Nullable to @org.jspecify.annotations.Nullable.

What's your motivation?

Spring treats its @nullable differently from JSpecify's @nullable, and for custom prometheus scrape endpoints, if you pass in @org.jspecify.annotations.Nullable Set<String> includedNames and includedNames is null, the entire scrape will fail.

Anything in particular you'd like reviewers to focus on?

N/A

Anyone you would like to review specifically?

N/A

Have you considered any alternatives or workarounds?

The workaround considered was forking or not using the MigrateToJSpecify recipe, but we would prefer to use the recipe.

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek timtebeek merged commit 20b8fff into main Nov 13, 2024
1 of 2 checks passed
@timtebeek timtebeek deleted the kmccarp-patch-1 branch November 13, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants