Prevent breakage of usages of Spring's @Nullable #602
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
I commented out the migration from
@org.springframework.lang.Nullable
to@org.jspecify.annotations.Nullable
.What's your motivation?
Spring treats its @nullable differently from JSpecify's @nullable, and for custom prometheus scrape endpoints, if you pass in
@org.jspecify.annotations.Nullable Set<String> includedNames
andincludedNames
is null, the entire scrape will fail.Anything in particular you'd like reviewers to focus on?
N/A
Anyone you would like to review specifically?
N/A
Have you considered any alternatives or workarounds?
The workaround considered was forking or not using the
MigrateToJSpecify
recipe, but we would prefer to use the recipe.Any additional context
Checklist