Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune/adjust static analysis recipes to work properly on Kotlin file. #136

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

kunli2
Copy link
Contributor

@kunli2 kunli2 commented Jul 18, 2023

Tune/adjust static analysis recipes to work properly on Kotlin file.
In this PR

  1. Separate NeedBraces recipe to not work on Kotlin files until AutoFormat support Kotlin well.
  2. Separate ReplaceLambdaWithMethodReference to Java and Kotlin files, to avoid it making breaking changes on Kotlin files.

@kunli2 kunli2 merged commit b3cec38 into main Jul 18, 2023
@kunli2 kunli2 deleted the kunli/kotlin-updates branch July 18, 2023 17:38
Comment on lines +70 to +72
private static class ReplaceLambdaWithMethodReferenceKotlinVisitor extends KotlinVisitor<ExecutionContext> {
// Implement Me
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the plan here? Should this be logged as an issue for improvement @kunli2 ?
Or is it mostly to prevent exceptions and not make any changes just yet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created #138 for tracking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants