RemoveUnusedLocalVariables fails inside case blocks (test)

[sfc-gh-dtran]

What's changed?

What's your motivation?

Fixes #152

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

• I've added unit tests to cover both positive and negative cases
• I've added the license header to any new files through ./gradlew licenseFormat
• I've used the IntelliJ auto-formatter on affected files
• I've updated the documentation (if applicable)

[timtebeek]

Appreciate you adding this test! There's a bit of an oddity where you also remove two other tests. Would you mind reverting that?

[sfc-gh-dtran]

Appreciate you adding this test! There's a bit of an oddity where you also remove two other tests. Would you mind reverting that?

Thanks, that was weird indeed. I re-added those missing tests.

[timtebeek]

Thanks! I've ran your test and briefly explored the options; the quickest thing we can do now to avoid making unwanted changes, is to simply skip unused variables defined in case statements. That's a bit unfortunate, but better than making the wrong change right now. We can then later look to also remove unused local variables inside case statements. Hope you agree!

[sfc-gh-dtran]

Thanks! I've ran your test and briefly explored the options; the quickest thing we can do now to avoid making unwanted changes, is to simply skip unused variables defined in case statements. That's a bit unfortunate, but better than making the wrong change right now. We can then later look to also remove unused local variables inside case statements. Hope you agree!

Thanks! I've actually already looked into this and it looks like the problem is with the DeleteStatement recipe not handling statements inside case blocks: adding a simple visitCaseBlock visitor fixed this; I can make a PR to rewrite so you can take a look at it

[timtebeek]

Ah yes please! A PR with a proper fix would be much appreciated; I figured to the least harm quickly, but proper handling is even better!