Simplify lambda blocks to expressions replaces return that is used to infer which overloaded method to pick #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… infer which overloaded method to pick
|
Note that there are no compiler warnings or errors reported |
|
Could this be a variant of #10 ? |
|
@kunli2 Merging this one was maybe a bit too soon; the test output here does not compile, and it should likely have been a test asserting no change was made. |
|
@timtebeek , Yes, sorry about that, I found it's a fork here but not a branch, so I am not able to make a change on it here, so I planned to fix this issue right away after merging this. |
|
Great thanks! Does this then also fix #10 ? |
|
@kunli2 thanks for this quick fix! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding a test for #162