Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand RemoveExtraSemicolons description #454

Merged
merged 8 commits into from
Jan 28, 2025
Merged

Conversation

MBoegers
Copy link
Contributor

What's changed?

Description was misleading and don't describe all changes.

What's your motivation?

Better understandability for recipes purpose.

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@MBoegers MBoegers added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 28, 2025
@MBoegers
Copy link
Contributor Author

@jrivadeneira, @Laurens-W one is enought.

Laurens-W
Laurens-W previously approved these changes Jan 28, 2025
@Laurens-W
Copy link
Contributor

Hold on, the description needs to end with a ., only just now saw the failed build

@Laurens-W Laurens-W dismissed their stale review January 28, 2025 18:54

build failed

Copy link
Contributor

@Laurens-W Laurens-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MBoegers
Copy link
Contributor Author

I've manually run the best practices with no further result, will merge without succeeding receive-pr action.

@MBoegers MBoegers merged commit ecaea14 into main Jan 28, 2025
1 of 2 checks passed
@MBoegers MBoegers deleted the fix/add-better-description branch January 28, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants