Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitRemote#normalize to support organizations prefixed with a number #4651

Merged
merged 6 commits into from
Nov 28, 2024

Conversation

bryceatmoderne
Copy link
Contributor

What's changed?

GitRemote#normalize was incorrectly identifying an organization starting with a number, such 1org, as a port number. These changes update the regex Pattern to match a numerical string up to a forward slash.

What's your motivation?

Some repositories such as https://github.com/1Remote/1Remote were failing to build using the Moderne CLI.

Anything in particular you'd like reviewers to focus on?

No

Anyone you would like to review specifically?

@pstreef

Have you considered any alternatives or workarounds?

No

Any additional context

No

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@bryceatmoderne bryceatmoderne changed the title Update GitRemote#normalize to support organizations prefixed with a number Update GitRemote#normalize to support organizations prefixed with a number Nov 6, 2024
@bryceatmoderne bryceatmoderne self-assigned this Nov 6, 2024
@timtebeek timtebeek added the bug Something isn't working label Nov 11, 2024
@bryceatmoderne bryceatmoderne marked this pull request as draft November 28, 2024 01:04
@bryceatmoderne bryceatmoderne marked this pull request as ready for review November 28, 2024 14:53
@bryceatmoderne bryceatmoderne merged commit a40fbb5 into main Nov 28, 2024
2 checks passed
@bryceatmoderne bryceatmoderne deleted the git-remote-orgs-with-number-prefix branch November 28, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants