Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial support for java references for yaml #4698
base: main
Are you sure you want to change the base?
Add initial support for java references for yaml #4698
Changes from 1 commit
258ca24
4e373c8
be0b255
1cf7636
a524878
89adb02
5eae2b0
264af3f
7756105
ec7d119
7daa23d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT this will now try to match any YAML scalar values against the regexp we have for Java identifiers. This seems wrong to me. I don't think there is any need to add this class here. Instead I would expect "domain-specific" implementations like
SpringReference
which look for type references in specific YAML documents (matching some given file name or similar).AFAIK Spring also allows config to be in YAML, so maybe we could provide an implementation for that.