Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Groovy declared constructors #4706

Merged
merged 3 commits into from
Nov 23, 2024
Merged

Conversation

knutwannheden
Copy link
Contributor

@knutwannheden knutwannheden commented Nov 23, 2024

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • rewrite-groovy/src/test/java/org/openrewrite/groovy/tree/BinaryTest.java
    • lines 209-209
  • rewrite-groovy/src/test/java/org/openrewrite/groovy/tree/ClassDeclarationTest.java
    • lines 297-297
    • lines 311-311
  • rewrite-groovy/src/test/java/org/openrewrite/groovy/tree/CompilationUnitTest.java
    • lines 130-130
  • rewrite-groovy/src/test/java/org/openrewrite/groovy/tree/MethodDeclarationTest.java
    • lines 189-189
  • rewrite-groovy/src/test/java/org/openrewrite/groovy/tree/VariableDeclarationsTest.java
    • lines 190-190

@knutwannheden knutwannheden merged commit d308e49 into main Nov 23, 2024
1 of 2 checks passed
@knutwannheden knutwannheden deleted the groovy-constructors branch November 23, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Groovy parser fails to parse constructor declarations
1 participant