Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more infos in error logs for decoding failure #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PuKoren
Copy link
Member

@PuKoren PuKoren commented Oct 4, 2021

@openrm/dev I would like to try adding more infos in this warn log to help debugging a situation where the log is triggered. Currently the error log only states:

[AMQP:encoding] JSON deserialization failed with an exception. Unexpected end of JSON input Value: <Buffer >

With the properties (headers, correlationId, replyTo) I think it would be enough for developers to start investigating.

What do you think?

Copy link
Contributor

@robjweiss robjweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants