Use the except syntax as intended (#525)

opensafely-core · Jul 12, 2024 · 811bda7 · 811bda7
1 parent 46f847c
commit 811bda7
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/airlock/views/request.py b/airlock/views/request.py
@@ -321,10 +321,10 @@ def request_submit(request, request_id):
 
     try:
         bll.submit_request(release_request, request.user)
+    except bll.IncompleteContextOrControls as exc:
+        messages.error(request, str(exc))
+        return redirect(release_request.get_url())
     except bll.RequestPermissionDenied as exc:
-        if isinstance(exc, bll.IncompleteContextOrControls):
-            messages.error(request, str(exc))
-            return redirect(release_request.get_url())
         raise PermissionDenied(str(exc))
 
     messages.success(request, "Request has been submitted")