Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the release files button until all files have attempted to upload the max number of times #771

Closed
Tracked by #746
rebkwok opened this issue Feb 12, 2025 · 0 comments · Fixed by #772
Closed
Tracked by #746
Assignees

Comments

@rebkwok
Copy link
Contributor

rebkwok commented Feb 12, 2025

Now that files upload asynchronously, a request might stay in Approved status for a while, until all the files have uploaded. Previously this only happened if a file upload errored.

Currently the frontend behaviour will be the same as it was before if a file upload errored (except that it doesn't say the release failed) - the status will be approved, and the release files button will still be enabled. Clicking it again will re-release the files (in the sense that it'll make another audit event and update the released-at date), but it won't affect the actual uploading that's in progress). We want to wait until files have all finished attempting to upload before letting the user try to re-release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant