Disable the release files button until all files have attempted to upload the max number of times #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update the functional tests
To identify uploading status of a file and an overall request. This will allow us to determine whether to disable or enable the "release files" button and what tooltips to show.
Modify the label, enabled state, and tooltip for the "release files" button based on whether the request is: - reviewed, yet to be released (enable, show label "release files") - approved, uploads still in progress (disable, show "re-release files") - approved, not all files uploaded, all non-uploaded files have been attempted the max times (enabled, show "re-release files")
madwort
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #771
Change the displayed status for "Approved" in the status pills to "Approved - Files uploading"
(Note that I haven't changed it in the main request overview panel, which is consistent with how we dislay other statuses that have a custom label (i.e. partially reviewed/reviewed))
When the request is approved, but files are still uploading, the "Release files" button is disabled, and changes to "Re-release files" (as in screenshot above).
When all files have been attempted 3x, and some are still not uploaded, the "Re-release files" button is enabled so that the user can re-try the release.
Tooltips when files are uploading (disabled re-release button):
And when uploads have tried and failed (enabled re-release button):
Note: tooltip placement is a bit wonky, but this is the case already and not something for this ticket.
Currently the page needs to be manually refreshed to see changes to the file upload status - I'm deliberately not handling this in this PR, there will be a follow up one to poll via htmx for upload status changes.
Preventing the user from re-trying the release is done in the frontend only. The BLL doesn't prohibit re-tries in the release_files() method. This was a conscious decision; nothing terrible happens if a user was to re-try unnecessarily - the audit log will register it, but if the file is already uploaded - and registered as such in the RequestFile, we won't attempt to re-upload it, and it a file was uploaded but not registered, we'd re-attempt it, but we handle already uploaded file errors from job-server.