Disable editing of context and controls for author when the request is under review #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebkwok
force-pushed
the
disable-context-controls
branch
3 times, most recently
from
296ec98 to
9a3718e
Compare
bloodearnest
approved these changes
Jul 16, 2024
|
Yeah, I spent a while trying to come up with a decent name for it. |
Commenting is only allowed if a request is - not final - is under review, and the user is an output-checker - is in draft, and the user has permission to accesss the workspace Note: in draft status, project collaborators are allowed to answer output checkers' questions, not just the author
rebkwok
force-pushed
the
disable-context-controls
branch
from
9a3718e to
92caf75
Compare
yeah, I think its a bit better if you feel like making the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable editing of context/controls for author when the request is under review
Fixes #537
Hide comments unless allowed to comment
Fixes #539
Commenting is only allowed if a request is
- not final
- is under review, and the user is an output-checker
- is in draft, and the user has permission to accesss the workspace