Add CI for r:v2, and publishing for r:v1 and r:v2 #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bloodearnest
force-pushed
the
ci
branch
10 times, most recently
from
53459b3 to
7566e0d
Compare
bloodearnest
force-pushed
the
ci
branch
20 times, most recently
from
5f075f8 to
67dd38c
Compare
bloodearnest
force-pushed
the
ci
branch
11 times, most recently
from
e67dcf2 to
fa31a3c
Compare
We can't do v1, as it takes too long to build in GHA.
bloodearnest
force-pushed
the
ci
branch
3 times, most recently
from
fa86e44 to
84f33d8
Compare
Do not run in CI, as too slow (2hours)
bloodearnest
changed the title
remlapmot
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change builds and tests v2 in CI, and then publishes r:v2 and rstudio:v2 after merging.
v1 also works, but takes ~2h, so is too slow for normal CI.
However, having to manually publish v1 is still a bit of a pain, and we want to ensure some level on consistency in deployment.
So, we do run build/test r:v1 and rstudio:v1 on
mainafter merging, and then deploy it. It takes 2 hours, but that's hopefully acceptable given we publish infrequently. And it gives us some level of assurance, as well as automating the deployment parts, so we no longer need to do that manually.Fixes #177